Discussion:
2.6.14-rc4-mm1 and later: second ata_piix controller is invisible
(too old to reply)
Max Kellermann
2005-10-25 09:56:46 UTC
Permalink
Hi Andrew,

since 2.6.14-rc4-mm1, my second ata_piix (SATA) controller does not
show up in dmesg, effectively hiding /dev/sdb. 2.6.14-rc2-mm2 and
older (with the same kernel config) were ok, the same for Linus'
kernels: 2.6.14-rc5 without -mm1 has /dev/sdb, too.

0000:00:1f.2 IDE interface: Intel Corp. 82801EB (ICH5) Serial ATA 150
Storage Controller (rev 02) (prog-if 8f [Master SecP SecO PriP PriO])
0000:00:1f.2 0101: 8086:24d1 (rev 02)

This PCI device (on-board on an Asus P4 mainboard) has two SATA
connectors, showing up as ata1/sda and ata2/sdb.

dmesg from 2.6.14-rc5:

libata version 1.12 loaded.
ata_piix version 1.04
ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 18 (level, low) -> IRQ 177
PCI: Setting latency timer of device 0000:00:1f.2 to 64
ata1: SATA max UDMA/133 cmd 0xEFE0 ctl 0xEFAE bmdma 0xEF60 irq 177
ata2: SATA max UDMA/133 cmd 0xEFA0 ctl 0xEFAA bmdma 0xEF68 irq 177
ata1: dev 0 cfg 49:2f00 82:7c6b 83:7b09 84:4003 85:7c69 86:3a01
87:4003 88:207f
ata1: dev 0 ATA, max UDMA/133, 240121728 sectors:
ata1: dev 0 configured for UDMA/133

dmesg from 2.6.14-rc5-mm1:

libata version 1.12 loaded.
ata_piix version 1.04
ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 18 (level, low) -> IRQ 193
PCI: Setting latency timer of device 0000:00:1f.2 to 64
ata1: SATA max UDMA/133 cmd 0xEFE0 ctl 0xEFAE bmdma 0xEF60 irq 193
ata1: dev 0 cfg 49:2f00 82:7c6b 83:7b09 84:4003 85:7c69 86:3a01
87:4003 88:207f
ata1: dev 0 ATA-7, max UDMA/133, 240121728 sectors: LBA
ata1: dev 0 configured for UDMA/133

Need more information? I could try to disable a few patches from your
-mm series if you name some.. it's too hard for me to guess which one
could be responsible for the breakage.

Max
Andrew Morton
2005-10-25 17:32:17 UTC
Permalink
Post by Max Kellermann
Hi Andrew,
since 2.6.14-rc4-mm1, my second ata_piix (SATA) controller does not
show up in dmesg, effectively hiding /dev/sdb. 2.6.14-rc2-mm2 and
older (with the same kernel config) were ok, the same for Linus'
kernels: 2.6.14-rc5 without -mm1 has /dev/sdb, too.
0000:00:1f.2 IDE interface: Intel Corp. 82801EB (ICH5) Serial ATA 150
Storage Controller (rev 02) (prog-if 8f [Master SecP SecO PriP PriO])
0000:00:1f.2 0101: 8086:24d1 (rev 02)
This PCI device (on-board on an Asus P4 mainboard) has two SATA
connectors, showing up as ata1/sda and ata2/sdb.
libata version 1.12 loaded.
ata_piix version 1.04
ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 18 (level, low) -> IRQ 177
PCI: Setting latency timer of device 0000:00:1f.2 to 64
ata1: SATA max UDMA/133 cmd 0xEFE0 ctl 0xEFAE bmdma 0xEF60 irq 177
ata2: SATA max UDMA/133 cmd 0xEFA0 ctl 0xEFAA bmdma 0xEF68 irq 177
ata1: dev 0 cfg 49:2f00 82:7c6b 83:7b09 84:4003 85:7c69 86:3a01
87:4003 88:207f
ata1: dev 0 configured for UDMA/133
libata version 1.12 loaded.
ata_piix version 1.04
ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 18 (level, low) -> IRQ 193
PCI: Setting latency timer of device 0000:00:1f.2 to 64
ata1: SATA max UDMA/133 cmd 0xEFE0 ctl 0xEFAE bmdma 0xEF60 irq 193
ata1: dev 0 cfg 49:2f00 82:7c6b 83:7b09 84:4003 85:7c69 86:3a01
87:4003 88:207f
ata1: dev 0 ATA-7, max UDMA/133, 240121728 sectors: LBA
ata1: dev 0 configured for UDMA/133
Need more information? I could try to disable a few patches from your
-mm series if you name some.. it's too hard for me to guess which one
could be responsible for the breakage.
Thanks. It'd be useful if you could test just 2.6.14-rc5+git-acpi.patch,
see if that does the same thing.
Max Kellermann
2005-10-26 06:50:28 UTC
Permalink
Post by Andrew Morton
It'd be useful if you could test just 2.6.14-rc5+git-acpi.patch,
see if that does the same thing.
And if that works OK, add git-libata-all.patch, retest.
results:

2.6.14-rc5 + git-acpi.patch + git-acpi-build-fix-2.patch:
ata2 and /dev/sdb are fine.

... + git-libata-all.patch
ata2 and /dev/sdb disappeared.

Tell me when you need further testing.

Max
Jeff Garzik
2005-10-29 19:25:49 UTC
Permalink
Post by Max Kellermann
Hi Andrew,
since 2.6.14-rc4-mm1, my second ata_piix (SATA) controller does not
show up in dmesg, effectively hiding /dev/sdb. 2.6.14-rc2-mm2 and
older (with the same kernel config) were ok, the same for Linus'
kernels: 2.6.14-rc5 without -mm1 has /dev/sdb, too.
0000:00:1f.2 IDE interface: Intel Corp. 82801EB (ICH5) Serial ATA 150
Storage Controller (rev 02) (prog-if 8f [Master SecP SecO PriP PriO])
0000:00:1f.2 0101: 8086:24d1 (rev 02)
This PCI device (on-board on an Asus P4 mainboard) has two SATA
connectors, showing up as ata1/sda and ata2/sdb.
Thanks for this report. Would it be possible for you to test 2.6.14
(release) and 2.6.14-git1, as additional data points?

Once its out, I might ask you to try 2.6.14-git2 (tonight's upcoming
snapshot) as well.

Regards,

Jeff
Jeff Garzik
2005-10-30 11:26:06 UTC
Permalink
Post by Max Kellermann
Hi Andrew,
since 2.6.14-rc4-mm1, my second ata_piix (SATA) controller does not
show up in dmesg, effectively hiding /dev/sdb. 2.6.14-rc2-mm2 and
older (with the same kernel config) were ok, the same for Linus'
kernels: 2.6.14-rc5 without -mm1 has /dev/sdb, too.
0000:00:1f.2 IDE interface: Intel Corp. 82801EB (ICH5) Serial ATA 150
Storage Controller (rev 02) (prog-if 8f [Master SecP SecO PriP PriO])
0000:00:1f.2 0101: 8086:24d1 (rev 02)
This PCI device (on-board on an Asus P4 mainboard) has two SATA
connectors, showing up as ata1/sda and ata2/sdb.
I think I found the bug. ata_pci_init_one() got confused about the
meaning of 'n_ports'. I also found another bug in the same area,
related to legacy initialization.

See the attached patch for a suggested fix (ignore ata_piix changes,
which are obviously unrelated).

Jeff
Jeff Garzik
2005-10-30 12:59:36 UTC
Permalink
Post by Max Kellermann
Hi Andrew,
since 2.6.14-rc4-mm1, my second ata_piix (SATA) controller does not
show up in dmesg, effectively hiding /dev/sdb. 2.6.14-rc2-mm2 and
older (with the same kernel config) were ok, the same for Linus'
kernels: 2.6.14-rc5 without -mm1 has /dev/sdb, too.
Attached is the patch I just checked in, which should play a bit more
nicely with Alan's PATA drivers than the last patch.

I was able to reproduce your (Max's) problem locally, and verified that
the attached patch fixed it.

Jeff
Max Kellermann
2005-10-31 10:33:27 UTC
Permalink
Post by Jeff Garzik
I was able to reproduce your (Max's) problem locally, and verified
that the attached patch fixed it.
I can confirm that. 2.6.14-rc5-mm1 plus your patch fixed my problem,
ata2 and /dev/sdb are available.

Max

Continue reading on narkive:
Loading...