Discussion:
[PATCH] drivers: net: xgene: Add missing initialization in xgene_enet_ecc_init()
(too old to reply)
Geert Uytterhoeven
2014-10-20 08:08:16 UTC
Permalink
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function =E2=80=98=
xgene_enet_ecc_init=E2=80=99:
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: =E2=80=98=
data=E2=80=99 may be used uninitialized in this function

Depending on the arbitrary value on the stack, the loop may terminate
too early, and cause a bogus -ENODEV failure.

Signed-off-by: Geert Uytterhoeven <***@linux-m68k.org>
---
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c b/driver=
s/net/ethernet/apm/xgene/xgene_enet_sgmac.c
index e6d24c2101982444..19e13583b4259cd4 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c
@@ -123,7 +123,7 @@ static u32 xgene_enet_rd_mac(struct xgene_enet_pdat=
a *p, u32 rd_addr)
static int xgene_enet_ecc_init(struct xgene_enet_pdata *p)
{
struct net_device *ndev =3D p->ndev;
- u32 data;
+ u32 data =3D 0;
int i;
=20
xgene_enet_wr_diag_csr(p, ENET_CFG_MEM_RAM_SHUTDOWN_ADDR, 0);
--=20
1.9.1
Iyappan Subramanian
2014-10-20 18:20:09 UTC
Permalink
On Mon, Oct 20, 2014 at 1:08 AM, Geert Uytterhoeven
Post by Geert Uytterhoeven
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function =E2=80=
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: =E2=80=
=98data=E2=80=99 may be used uninitialized in this function
Post by Geert Uytterhoeven
Depending on the arbitrary value on the stack, the loop may terminate
too early, and cause a bogus -ENODEV failure.
---
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c b/driv=
ers/net/ethernet/apm/xgene/xgene_enet_sgmac.c
Post by Geert Uytterhoeven
index e6d24c2101982444..19e13583b4259cd4 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c
@@ -123,7 +123,7 @@ static u32 xgene_enet_rd_mac(struct xgene_enet_pd=
ata *p, u32 rd_addr)
Post by Geert Uytterhoeven
static int xgene_enet_ecc_init(struct xgene_enet_pdata *p)
{
struct net_device *ndev =3D p->ndev;
- u32 data;
+ u32 data =3D 0;
int i;
xgene_enet_wr_diag_csr(p, ENET_CFG_MEM_RAM_SHUTDOWN_ADDR, 0);
--
1.9.1
Acked-by: Iyappan Subramanian <***@apm.com>

Continue reading on narkive:
Loading...